-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: concurrent cy.prompt() and Studio bundle download issues
#33034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ryanthemanuel
merged 9 commits into
develop
from
ryanm/chore/slight-refactor-for-ensuring-bundles
Dec 2, 2025
Merged
fix: concurrent cy.prompt() and Studio bundle download issues
#33034
ryanthemanuel
merged 9 commits into
develop
from
ryanm/chore/slight-refactor-for-ensuring-bundles
Dec 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/chore/slight-refactor-for-ensuring-bundles
|
| Run status |
|
| Run duration | 19m 25s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
10
|
|
|
1097
|
|
|
4
|
|
|
26698
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.61%
|
|
|---|---|
|
|
187
|
|
|
161
|
Accessibility
98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
cy.prompt() and Studio bundle download issues
ryanthemanuel
commented
Dec 1, 2025
ryanthemanuel
commented
Dec 2, 2025
mschile
approved these changes
Dec 2, 2025
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The existing error when the
cy.promptbundle is prematurely deleted off disk is less than helpful. It's also possible that we are deleting the bundle while other Cypress instances are accessing it. This PR:cy.promptbundle is no longer properly availableSteps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Make Cloud bundle downloads/extraction atomic and add clearer cy.prompt error handling, with tests and changelog updates.
extractAtomicto extract tar entries atomically usingwrite-file-atomic.ensure_cy_prompt_bundleandensure_studio_bundleto download to a uniquebundle.tar-*temp file and atomically extract to the target directory; clean up temp file afterward.[email protected].extractAtomicand update bundle ensure specs accordingly.cy.promptremote init/load in try/catch; on failure, throwprompt.promptBundleNeedsRefresh.promptBundleNeedsRefreshinerror_messages.ts.CHANGELOG.mdwith bugfix entry for atomic Cloud bundle writes and improvedcy.prompt()error message.Written by Cursor Bugbot for commit 8c10e75. This will update automatically on new commits. Configure here.